Skip to content

security: add curl timeouts to prevent script hanging#546

Merged
danyalprout merged 1 commit into
base:mainfrom
DeVikingMark:devikingmark
Oct 8, 2025
Merged

security: add curl timeouts to prevent script hanging#546
danyalprout merged 1 commit into
base:mainfrom
DeVikingMark:devikingmark

Conversation

@DeVikingMark

Copy link
Copy Markdown
Contributor

Add connection and maximum timeouts to curl commands in op-node-entrypoint

  • Add --max-time 10 and --connect-timeout 5 to curl in get_public_ip()
  • Add same timeouts to curl in execution client readiness check
  • Prevents script hanging when external IP services are slow/unavailable
  • Improves reliability and security of node startup process

@cb-heimdall

cb-heimdall commented Sep 20, 2025

Copy link
Copy Markdown
Collaborator

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@danyalprout
danyalprout merged commit fe34377 into base:main Oct 8, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants