Fix auditable-tables shield crashing on insert_all/upsert_all

[rosa]

Problem

The auditable-tables shield (ProtectedAuditableTables) wraps the connection's query methods and does:

sql = args.first
if Console1984.command_executor.executing_user_command? && sql.b =~ auditable_tables_regexp

It assumes args.first is a SQL String. But exec_insert_all receives an ActiveRecord::InsertAll, which doesn't respond to #b. So any insert_all/upsert_all run from an audited console raises:

NoMethodError: undefined method 'b' for an instance of ActiveRecord::InsertAll

It's invisible in normal web/job traffic because the check is short-circuited by executing_user_command? — it only bites in the console. In practice it blows up routine maintenance: e.g. updating a record whose callbacks insert_all (assignment summaries, backlinks, …) dies mid-way, sometimes rolling back the whole transaction.

Fix

Coerce the argument before the auditable-tables check. For a non-String, use its target table name (InsertAll#model.table_name) so the regexp still correctly detects — and forbids — access to audited tables. The underlying adapter still receives the original argument untouched, and string SQL behavior is unchanged.

def auditable_sql(sql)
  string = sql.is_a?(String) ? sql : (sql.try(:model)&.table_name || sql.to_s)
  string.b
end

Tests

Added test/ext/active_record/protected_auditable_tables_test.rb:

• an InsertAll-shaped arg for a non-auditable table is allowed and passed through untouched (the regression);
• an InsertAll for an auditable table is still forbidden;
• string SQL is still checked against auditable tables (unchanged).

Full suite: 86 runs, 374 assertions, 0 failures, 0 errors. bin/rubocop clean.

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Fixes a console-only crash in the ActiveRecord auditable-tables shield when exec_insert_all receives an ActiveRecord::InsertAll object (which doesn’t implement #b) by normalizing the “SQL” input used for the auditable-table regexp check.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Changes:

• Introduced auditable_sql(sql) to safely derive a String for audited-table detection (supports String and InsertAll-like objects via model.table_name fallback).
• Updated the guarded adapter method wrappers to use auditable_sql(sql) instead of calling #b directly on the first argument.
• Added regression tests covering InsertAll-shaped args for both auditable and non-auditable tables, plus existing string-SQL behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
lib/console1984/ext/active_record/protected_auditable_tables.rb	Normalizes the first adapter argument into a String before applying the auditable-table regexp check to avoid #b crashes on non-String inputs.
test/ext/active_record/protected_auditable_tables_test.rb	Adds targeted tests ensuring exec_insert_all works with InsertAll-like inputs and still blocks access to auditable tables.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.