Skip to content

Update lexxy to fix # prompt editor freeze#2731

Draft
jorgemanrubia wants to merge 2 commits intomainfrom
jorge/update-lexxy-hash-prompt-fix
Draft

Update lexxy to fix # prompt editor freeze#2731
jorgemanrubia wants to merge 2 commits intomainfrom
jorge/update-lexxy-hash-prompt-fix

Conversation

@jorgemanrubia
Copy link
Member

Summary

  • Updates lexxy from version pin to github main (4b718b0) which includes the fix for the editor freeze when typing # followed by space
  • The race condition caused selectionTransform crashes when the markdown heading shortcut consumed the # trigger during async prompt loading (RemoteFilterSource debounce)
  • Three race paths fixed: during first popover load, after visible popover, and during cached popover reload

Fixes https://app.fizzy.do/5986089/cards/3454
Lexxy PR: basecamp/lexxy#881

Copilot AI review requested due to automatic review settings March 19, 2026 13:57
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the app’s Lexxy dependency to pull from the basecamp/lexxy GitHub main branch (locked to commit 4b718b0…) to address the prompt editor freeze when typing # + space.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Changes:

  • Switch Lexxy from a Rubygems version pin to the GitHub main branch in Gemfile.
  • Update Gemfile.lock to lock Lexxy to the specified Git revision and reflect dependency resolution updates.

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
Gemfile Moves Lexxy to a GitHub-sourced dependency on main.
Gemfile.lock Locks Lexxy to the target commit and updates resolved dependency versions.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@jorgemanrubia jorgemanrubia force-pushed the jorge/update-lexxy-hash-prompt-fix branch from 17d3892 to 80b3ccc Compare March 19, 2026 14:01
Point lexxy to main which includes the fix for the editor freeze
when typing # followed by space. The race condition caused
selectionTransform crashes when the markdown heading shortcut
consumed the trigger during async prompt loading.

Fixes https://app.fizzy.do/5986089/cards/3454
@jorgemanrubia jorgemanrubia force-pushed the jorge/update-lexxy-hash-prompt-fix branch from 80b3ccc to 6e09c16 Compare March 19, 2026 14:02
Copilot AI review requested due to automatic review settings March 19, 2026 14:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the lexxy dependency to a specific GitHub main revision that includes the upstream fix for the prompt editor freezing when typing # followed by a space (selection transform race during async prompt loading).

Changes:

  • Switch lexxy in Gemfile from a version pin to the Basecamp GitHub repo main branch.
  • Update both Gemfile.lock and Gemfile.saas.lock to lock lexxy to revision 4b718b0….
  • Convert dependency entries to Bundler’s git-source form (lexxy!) in lockfiles.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated 1 comment.

File Description
Gemfile Sources lexxy from the Basecamp GitHub repo main branch.
Gemfile.lock Locks lexxy to the specified git revision for the default bundle.
Gemfile.saas.lock Locks lexxy to the specified git revision for the SaaS bundle.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings March 19, 2026 18:48
@jorgemanrubia jorgemanrubia marked this pull request as draft March 19, 2026 18:49
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the app’s Lexxy dependency from a RubyGems version pin to the Basecamp GitHub main branch (locked to revision 4b718b0…) to pick up upstream fixes for the # + space prompt/editor freeze in Lexxy.

Changes:

  • Switch lexxy in Gemfile from 0.8.5.beta to the Basecamp GitHub repo on main.
  • Update both lockfiles to reflect Lexxy being sourced from Git (and record the exact revision).

Reviewed changes

Copilot reviewed 1 out of 3 changed files in this pull request and generated no comments.

File Description
Gemfile Moves lexxy from a version pin to bc: "lexxy", branch: "main".
Gemfile.lock Records Lexxy as a Git dependency at revision 4b718b0… and updates dependency metadata.
Gemfile.saas.lock Mirrors the Lexxy Git dependency change for the SaaS bundle lockfile.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants