Fix invisible inline code background in dark theme#2734
Open
jorgemanrubia wants to merge 1 commit intomainfrom
Open
Fix invisible inline code background in dark theme#2734jorgemanrubia wants to merge 1 commit intomainfrom
jorgemanrubia wants to merge 1 commit intomainfrom
Conversation
The code element background used var(--color-canvas), which in dark mode resolves to the same color as the page background, making inline code elements invisible. Switch to var(--color-ink-lighter) for the background and var(--color-ink-light) for the border so inline code is visually distinguishable. Fixes Fizzy card #5003
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves readability of inline <code> styling in dark theme by adjusting the background and border colors so inline code remains visually distinguishable in card descriptions/comments (Lexxy content) and card titles.
Changes:
- Update
.lexxy-content codeto use--color-ink-lighterbackground and--color-ink-lightborder. - Update
.card__title codeto use the same background/border tokens for consistency.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/assets/stylesheets/lexxy.css | Adjusts inline code background/border colors within Lexxy-rendered content to improve dark-theme contrast. |
| app/assets/stylesheets/cards.css | Aligns inline code styling in card titles with the updated Lexxy inline code color tokens. |
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<code>elements in card descriptions and comments usedvar(--color-canvas)as their background color, which in the dark theme resolves to nearly the same color as the card/page background, making them invisiblevar(--color-ink-lighter)and border tovar(--color-ink-light)in bothlexxy.css(.lexxy-content context) andcards.css(.card__title context) so inline code is visually distinguishableFixes card #5003
Ref: https://app.3.basecamp.com/2914079/buckets/46292715/card_tables/cards/9679552612#__recording_9679695384