fix: Post button still disabled after pasting text#2942
Open
bfanger wants to merge 1 commit into
Open
Conversation
…er the paste command has been processed
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adjusts the form controller’s submit-disabling behavior by adding an additional frame delay before checking form validity.
Changes:
- Adds a second
await nextFrame()before runningcheckValidity()indisableSubmitWhenInvalid.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
77
to
+79
| async disableSubmitWhenInvalid(event) { | ||
| await nextFrame() | ||
| await nextFrame() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The checkValidity() is always one step behind ( this might be an issue with lexxy that fires the change event too soon )
The issue
This is not much of an issue when typing a comment, as that is generally more than 1 character.
But when pasting content is an issue, as demonstated here:
Fix
The fix was to wait two frames, instead of one, so the checkValidity() is based on contents after the command has been processed.