Skip to content

Set Secure flag on kamal writer cookie when TLS is active #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AnyCPU wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Set Secure flag on kamal writer cookie when TLS is active #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions internal/server/load_balancer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ func (lb *LoadBalancer) StartRequest(w http.ResponseWriter, r *http.Request) fun
}

if lb.writerAffinityTimeout > 0 && lb.hasReaders && !readRequest {
w = newLoadBalancerReponseWriter(w, lb.writerAffinityTimeout)
w = newLoadBalancerReponseWriter(w, lb.writerAffinityTimeout, r.TLS != nil)
}

lb.setTargetHeader(req, target)
Expand Down Expand Up @@ -302,13 +302,15 @@ type loadBalancerResponseWriter struct {
http.ResponseWriter
headerWritten bool
writerAffinityTimeout time.Duration
secure bool
}

func newLoadBalancerReponseWriter(w http.ResponseWriter, writerAffinityTimeout time.Duration) *loadBalancerResponseWriter {
func newLoadBalancerReponseWriter(w http.ResponseWriter, writerAffinityTimeout time.Duration, secure bool) *loadBalancerResponseWriter {
return &loadBalancerResponseWriter{
ResponseWriter: w,
headerWritten: false,
writerAffinityTimeout: writerAffinityTimeout,
secure: secure,
}
}

Expand Down Expand Up @@ -352,6 +354,7 @@ func (w *loadBalancerResponseWriter) setWriterAffinityCookie() {
Value: strconv.FormatInt(expires.UnixMilli(), 10),
Path: "/",
HttpOnly: true,
Secure: w.secure,
Expires: expires.Add(time.Second),
}

Expand Down