Skip to content

make socket path configurable#212

Open
braun2morrow wants to merge 1 commit intobasecamp:mainfrom
braun2morrow:socket-path
Open

make socket path configurable#212
braun2morrow wants to merge 1 commit intobasecamp:mainfrom
braun2morrow:socket-path

Conversation

@braun2morrow
Copy link
Copy Markdown

Read the envvar KAMAL_PROXY_SOCKET to determine the control socket path.
This makes it possible to control a running kamal-proxy instance from a
different user, by making the socket accessible via file system
permissions.

If KAMAL_PROXY_SOCKET is unset, retain the previous
${XDG_RUNTIME_DIR:/tmp}/kamal-proxy.sock
behaviour.

Read the envvar KAMAL_PROXY_SOCKET to determine the control socket path.
This makes it possible to control a running kamal-proxy instance from a
different user, by making the socket accessible via file system
permissions.

If KAMAL_PROXY_SOCKET is unset, retain the previous
${XDG_RUNTIME_DIR:/tmp}/kamal-proxy.sock
behaviour.
Copilot AI review requested due to automatic review settings April 23, 2026 11:51
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an environment-variable override for the kamal-proxy control socket path so operators can place the socket in a location with appropriate filesystem permissions (e.g., to allow controlling a running instance from a different user). When KAMAL_PROXY_SOCKET is not set (or is empty), behavior remains the same as before: ${XDG_RUNTIME_DIR:-/tmp}/kamal-proxy.sock.

Tip

If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

Changes:

  • Read KAMAL_PROXY_SOCKET to determine the control socket path.
  • Preserve the existing default socket path when the env var is not provided.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants