make socket path configurable#212
Open
braun2morrow wants to merge 1 commit intobasecamp:mainfrom
Open
Conversation
Read the envvar KAMAL_PROXY_SOCKET to determine the control socket path.
This makes it possible to control a running kamal-proxy instance from a
different user, by making the socket accessible via file system
permissions.
If KAMAL_PROXY_SOCKET is unset, retain the previous
${XDG_RUNTIME_DIR:/tmp}/kamal-proxy.sock
behaviour.
There was a problem hiding this comment.
Pull request overview
Adds an environment-variable override for the kamal-proxy control socket path so operators can place the socket in a location with appropriate filesystem permissions (e.g., to allow controlling a running instance from a different user). When KAMAL_PROXY_SOCKET is not set (or is empty), behavior remains the same as before: ${XDG_RUNTIME_DIR:-/tmp}/kamal-proxy.sock.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Changes:
- Read
KAMAL_PROXY_SOCKETto determine the control socket path. - Preserve the existing default socket path when the env var is not provided.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read the envvar KAMAL_PROXY_SOCKET to determine the control socket path.
This makes it possible to control a running kamal-proxy instance from a
different user, by making the socket accessible via file system
permissions.
If KAMAL_PROXY_SOCKET is unset, retain the previous
${XDG_RUNTIME_DIR:/tmp}/kamal-proxy.sock
behaviour.