Skip to content

Fix self-demo BATS fixture path portability#1323

Merged
codeforester merged 1 commit into
mainfrom
fix/1322-20260630-demo-bats-fixture-path
Jul 1, 2026
Merged

Fix self-demo BATS fixture path portability#1323
codeforester merged 1 commit into
mainfrom
fix/1322-20260630-demo-bats-fixture-path

Conversation

@codeforester

Copy link
Copy Markdown
Collaborator

Summary

  • Replace the hard-coded personal base-bash-libs path in the self-demo BATS pause test with the existing portable fixture resolver.
  • Add a contract check that prevents that personal path from returning to the BATS test.

Root Cause

The self-demo pause test used /Users/rameshhp/work/base-bash-libs/lib/bash as a fallback BASE_BASH_LIBS_DIR. That works on the primary macOS checkout but fails on fresh Ubuntu source checkouts, so the test exits before exercising the terminal-fd pause behavior.

Validation

  • PYTHONPATH=/Users/rameshhp/work/base/lib/python:/Users/rameshhp/work/base/cli/python /Users/rameshhp/.base.d/base/.venv/bin/python -m pytest tests/test_contract_hardening.py -q
  • bats cli/bash/commands/basectl/tests/demo.bats
  • git diff --check
  • Prior full local gate after this patch: env -u BASE_HOME ./bin/base-test -> Python 731 passed, 1 skipped; BATS 569 ok

Fixes #1322

@codeforester codeforester marked this pull request as ready for review July 1, 2026 03:51
@codeforester codeforester requested a review from a team as a code owner July 1, 2026 03:51
@codeforester codeforester merged commit 8dda63f into main Jul 1, 2026
24 checks passed
@codeforester codeforester deleted the fix/1322-20260630-demo-bats-fixture-path branch July 1, 2026 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix self-demo BATS fixture path portability

1 participant