Skip to content

fix(ci): resolve security audit job failure #44

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bashandbone merged 5 commits into from
Apr 4, 2026
Merged

fix(ci): resolve security audit job failure #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c4b8465
Initial plan
Copilot Mar 24, 2026
17e98dc
fix: resolve security audit CI failure - add checks:write permission …
Copilot Mar 24, 2026
48d8716
Update checkout action from v4 to v6
bashandbone Apr 4, 2026
860c5dc
Add advisory to ignore list in audit.toml
bashandbone Apr 4, 2026
fe232a6
Update audit.toml
bashandbone Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
- beta
- nightly
steps:
- uses: actions/checkout@v4
- uses: actions/checkout@v6
with:
submodules: recursive

Expand Down Expand Up @@ -69,12 +69,15 @@ jobs:
security_audit:
name: Security Audit
runs-on: ubuntu-latest
permissions:
checks: write
contents: read
steps:
- uses: actions/checkout@v6
- uses: rustsec/audit-check@v1.4.1
with:
token: ${{ secrets.GITHUB_TOKEN }}
ignore: RUSTSEC-2024-0364
ignore: RUSTSEC-2024-0364,RUSTSEC-2024-0436
Comment on lines 78 to +80

Copilot AI Apr 4, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rustsec/audit-check is configured to ignore RUSTSEC-2024-0436 here, but the repo also has an audit.toml (used for cargo audit) that currently only ignores RUSTSEC-2024-0364. Consider adding RUSTSEC-2024-0436 to audit.toml too so local cargo audit runs and any future CI usage of the config file stay consistent with this workflow ignore list.

Copilot uses AI. Check for mistakes.

coverage:
name: Code Coverage
Expand Down
1 change: 1 addition & 0 deletions audit.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,5 @@
[advisories]
ignore = [
"RUSTSEC-2024-0364", # gitoxide-core does not neutralize special characters for terminals. No patched version available.
"RUSTSEC-2024-0436" # No patched version available.
]
1 change: 1 addition & 0 deletions deny.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,7 @@ feature-depth = 1
# output a note when they are encountered.
ignore = [
"RUSTSEC-2024-0364", # gitoxide-core does not neutralize special characters for terminals. No patched version available.
"RUSTSEC-2024-0436", # paste is unmaintained; it is a transitive dependency via rustls-ffi -> macro_rules_attribute and has no patched version or security impact.
# "RUSTSEC-0000-0000",
# { id = "RUSTSEC-0000-0000", reason = "you can specify a reason the advisory is ignored" },
# "a-crate-that-is-yanked@0.1.1", # you can also ignore yanked crate versions if you wish
Expand Down
Loading