Conversation
MandarinSmell
left a comment
MandarinSmell
left a comment
There was a problem hiding this comment.
There's problem with your approach of touching max HP of entity. I'm aware why you chose this way, but you should not directly modify max HP. Please consider other approach. Rests of code seems to be fine
There was a problem hiding this comment.
You should not open core code repository with any IDE. This repository is supposed to be submodule of other repository. For example, you just open BCU PC project, git clone this repository, and put it under "[BCU PC Project Folder]/src/main/java/" and rename clone folder to "common". Please remove all of these IDEA project folders and files
|
|
||
|
|
There was a problem hiding this comment.
Please remove unnecessary linebreaks
|
|
||
| // set how much health to revive with | ||
| long reviveHealth = e.maxH * maxR / 100; | ||
|
|
||
| // if revive health exceeds max health, update the max health | ||
| if (reviveHealth > e.maxH) | ||
| { | ||
| e.maxH = reviveHealth; | ||
| e.health = e.maxH; | ||
| } | ||
|
|
||
| // otherwise set health as normal | ||
| else | ||
| { | ||
| e.health = reviveHealth; | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
I know this idea would be good, but please don't touch maximum HP as it will ruin interaction between healing. Touching maxH means this entity's max HP is changed forever until it dies. This would be interpreted as just dirty patch to solve problem of entity not being able to have extra HP than it can have due to limitation of maxH. You will have to use other approach than this one
| if (!(ctargetable(atk.trait, atk.attacker, false) || (receive(-1) && atk.SPtr) || (receive(1) && !atk.SPtr))) | ||
| return; | ||
|
|
||
|
|
There was a problem hiding this comment.
Unnecessary linebreak
2 participants
Added ability for zombies to revive above 100% and option to let venom scale with magnifications.