Skip to content

Introduce zip prefix and suffix#79

Merged
norgevz merged 6 commits intobattre:mainfrom
m-maryia:introduce-zip-prefix-and-suffix
Jul 22, 2025
Merged

Introduce zip prefix and suffix#79
norgevz merged 6 commits intobattre:mainfrom
m-maryia:introduce-zip-prefix-and-suffix

Conversation

@m-maryia
Copy link
Copy Markdown
Collaborator

No description provided.

Copy link
Copy Markdown
Collaborator

@norgevz norgevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Regular expression pattern to match a sequence of alphanumeric chars.
kAlphaNumericSequenceRe:
regex_fragment:
(?:[^\W_]+)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind moving the kAlphaNumericSequenceRe closer to the top of the file? It's a more general regex that can be reused for other purposes.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@norgevz norgevz merged commit 4fec726 into battre:main Jul 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants