Fix filepaths with space#540
Conversation
|
Thanks for the fix! I think the e2e tests are not necessary since they are more of a smoke test. If you could remove the e2e tests then I'll merge the fix! |
d8251f1 to
7a7d8f9
Compare
|
Remove e2e tests and added a few more unit tests for resources and references with whitespace. |
|
Don't worry about the failed Buildifier. I'll fix that after I merge. |
|
|
|
After doing more testing I found that the fsharp compiler doesn't strip the double quotes it includes them in the output. Will revert change and add tests for fsharp to assert no quotes are added. |
99a5960 to
b22b8ba
Compare
|
Pushed the change to ensure F# compiler doesn't add quotes. Quotes do work for source file but not anything else. |
I found an issue where if a file path has a space "foo/api tests/some_test.cs" then the compile would fail. This seems to only happen with csharp compiler. I think the fsharp compiler sends each cli argument as a new line which makes it support spaces in folder and file names.
I can add more tests as well to test each possible case. First time looking into this code base maybe there's a better way to handle it as well.