Skip to content

Conversation

@rickeylev
Copy link
Collaborator

Starting in bazel 10, the build_python_zip flag is removed. This means using
the flag in e.g. transitions no longer works, which breaks some of the tests
that set the flag for testing.

To fix, don't set the flags or add them to transitions when running under
bazel 10.

Fixes #3496

@rickeylev rickeylev requested a review from aignas as a code owner January 12, 2026 00:10
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the project to maintain compatibility with Bazel 10 by making the build_python_zip flag optional in test configurations and transitions. The changes ensure that tests continue to pass without errors in newer Bazel environments where this flag is no longer supported, while still functioning correctly in older versions.

Highlights

  • Bazel 10 Compatibility: The pull request addresses compatibility issues with Bazel 10, where the build_python_zip flag has been removed, causing existing tests to fail.
  • Conditional Flag Usage: Introduced a mechanism to conditionally apply the build_python_zip flag in tests and transitions, ensuring it is only used when running on Bazel versions prior to 10.
  • Bazel Version Detection: Added bazel_10_or_later to the internal configuration, allowing rules to dynamically adapt their behavior based on the detected Bazel version.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the build configuration and tests to be compatible with Bazel 10, where the build_python_zip flag is removed. The changes correctly introduce a bazel_10_or_later configuration flag and use it to conditionally apply the build_python_zip flag in tests and transitions. My review includes a couple of suggestions to improve code consistency and clarity for better long-term maintainability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bazel CI] ERROR: CI build failure: Starlark transition for build_python_zip returns invalid settings

1 participant