[9.2.0] Add //tools:tools_for_bazel_subcommands filegroup to vendor mod tidy …

[iancha1992]

…deps (#29445)

bazel vendor //... does not vendor the implicit @buildozer_binary dependency of bazel mod tidy, so a subsequent bazel mod tidy run with --vendor_dir and --nofetch fails with:

ERROR: no such package '@@buildozer++buildozer_binary+buildozer_binary//':
no such package '@@buildozer+//': Vendored repository buildozer+ not found
under the vendor directory and fetching is disabled.

Users currently have to discover and pass the undiscoverable incantation --repo=@@buildozer+ --repo=@@buildozer++buildozer_binary+buildozer_binary.

See #29222 for the full discussion. @fmeum proposed the fix adopted here:

We could add a target under bazel_tools that groups all such tools and that you could add to your vendor pattern list for this purpose.

The reporter confirmed this approach works for their use case.

Add a new public filegroup @bazel_tools//tools:tools_for_bazel_subcommands that groups implicit tool dependencies of Bazel subcommands. Today it contains just @buildozer_binary//:buildozer.exe (required by bazel mod tidy); future subcommands that introduce implicit tool deps can be added here.

Users who run Bazel offline with --vendor_dir and --nofetch can opt in by including the target in their vendor invocation:

bazel vendor //... @bazel_tools//tools:tools_for_bazel_subcommands

This preserves the current behavior for users who don't run bazel mod tidy (no silent expansion of the transitive closure) while giving those who do run it a single, documented target to add to their vendor pattern.

Added test_tools_for_bazel_subcommands in src/test/shell/bazel/bazel_tools_test.sh that queries the new filegroup and asserts buildozer is in its transitive dependencies.

Add `@bazel_tools//tools:tools_for_bazel_subcommands` filegroup that groups implicit tool dependencies of Bazel subcommands (e.g. buildozer for `bazel mod tidy`). Add this target to `bazel vendor` when working offline.

Fixes #29222

Closes #29445.

PiperOrigin-RevId: 910718201
Change-Id: I776833cf65624b67425f85a74d0891316f1ed40e

Description

Motivation

Build API Changes

No

Checklist

• I have added tests for the new use cases (if any).
• I have updated the documentation (if applicable).

Release Notes

RELNOTES: None

Commit 29477bc