Skip to content

BADGER-364: Remove UHD overrides #426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JoeBBC merged 4 commits into from
Apr 23, 2026
Merged

BADGER-364: Remove UHD overrides #426

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
69fba61
chore: updated dash.js (v4.7.3-19)
JoeBBC Apr 7, 2026
9a6a9eb
chore: removed uhd override from legacy adaper's disableSentinels check
JoeBBC Apr 21, 2026
e63715a
chore: remove uhd sentinel override
JoeBBC Apr 22, 2026
2faffc4
Merge branch 'master' into BADGER-364-RemoveUhdOverrides
JoeBBC Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion docs/tutorials/01-settings-and-overrides.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ In order to add an override, simply add an override object to the `window.bigscr
| `restartTimeout` | This is used after a seek attempted to ensure that a seek has happened correctly. | number |
| `disableMediaSourceUnload` | When tearing down in HTML5 we unload the source as part of the html5 spec. This prevents this from happening as it was causing issues on devices. | boolean |
| `legacySubtitles` | This can be used to render subtitles using our legacy method, rather than the new method which utilises the third party imscJS library. | boolean |
| `liveUhdDisableSentinels` | Disables any sentinels when consuming live UHD content | boolean |
| `cacheSeekableRange` | Caches the seekable range so it can't be requested more than every 250ms for devices that struggle. | boolean |
| `resetMSEPlayer` | Forces the `dash.js` MediaPlayer and HTML MediaElement to be fully destroyed/removed when `reset()` is called on the MSE Strategy. Reset is called from `playerComponent.js` on a CDN failover, and usually does nothing (allowing a new source to be attached to the current Media Player). | boolean |

Expand Down
3 changes: 1 addition & 2 deletions src/playbackstrategy/legacyplayeradapter.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,7 @@ function LegacyPlayerAdapter(mediaSources, playbackElement, isUHD, player) {
const manifestType = mediaSources.time().manifestType

const setSourceOpts = {
disableSentinels:
!!isUHD && manifestType === ManifestType.DYNAMIC && window.bigscreenPlayer?.overrides?.liveUhdDisableSentinels,
disableSentinels: false,
disableSeekSentinel: !!window.bigscreenPlayer?.overrides?.disableSeekSentinel,
}

Expand Down
27 changes: 0 additions & 27 deletions src/playbackstrategy/legacyplayeradapter.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,33 +239,6 @@ describe("Legacy Playback Adapter", () => {
}
)

it("should disable all sentinels for a dynamic UHD stream when configured to do so", () => {
window.bigscreenPlayer.overrides = {
liveUhdDisableSentinels: true,
}

mockMediaSources.time.mockReturnValueOnce({ manifestType: ManifestType.DYNAMIC })
mockMediaSources.currentSource.mockReturnValueOnce("mock://media.src/")

const isUHD = true
const mediaPlayer = createMockMediaPlayer()

const legacyAdapter = LegacyAdapter(mockMediaSources, playbackElement, isUHD, mediaPlayer)

legacyAdapter.load("video/mp4")

expect(mediaPlayer.initialiseMedia).toHaveBeenCalledWith(
"video",
"mock://media.src/",
"video/mp4",
playbackElement,
{
disableSeekSentinel: false,
disableSentinels: true,
}
)
})

it("should disable seek sentinels if we are configured to do so", () => {
window.bigscreenPlayer.overrides = {
disableSeekSentinel: true,
Expand Down
Loading