WS-NA: Ignore uuid advisory due to 7 day rule#13949
Merged
Isabella-Mitchell merged 1 commit intolatestfrom Apr 23, 2026
Merged
Conversation
HarveyPeachey
approved these changes
Apr 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Simorgh’s Yarn configuration to suppress a newly reported uuid npm audit advisory, aligning CI/security reporting with the “7 day rule” approach referenced in the PR title.
Changes:
- Added GitHub advisory
1116970(GHSA-w5hq-g745-h8pq) tonpmAuditIgnoreAdvisories.
|
|
||
| npmAuditIgnoreAdvisories: | ||
| - 1112686 # https://github.com/advisories/GHSA-p5wg-g6qr-c7cg | ||
| - 1116970 # https://github.com/advisories/GHSA-w5hq-g745-h8pq |
There was a problem hiding this comment.
npmAuditIgnoreAdvisories entries are security exceptions; this new ignore only links the GHSA but doesn’t capture why it’s acceptable here (e.g. JIRA/WS-NA context, whether it’s dev-only / non-exploitable in this repo) or when it should be removed. Please expand the inline comment to include the tracking ticket and a review/removal date so the ignore doesn’t become permanent by default.
Suggested change
| - 1116970 # https://github.com/advisories/GHSA-w5hq-g745-h8pq | |
| - 1116970 # https://github.com/advisories/GHSA-w5hq-g745-h8pq; temporary exception for this repo only because the affected path is non-exploitable here / dev-only as assessed during review; tracking ticket: WS-NA-TODO; review or remove by: YYYY-MM-DD |
Louis-Matsika
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: N/A
Summary
Resolves advisory to permit merging into latest. See thread. Replaces #13945 for now.
Code changes
Testing
Useful Links