Remove the spotlight feature#631
Merged
Merged
Conversation
Spotlight synced a task worktree's git-tracked files into the main repo so the running app could be exercised against in-progress changes. It went unused and is superseded by running the app directly from the worktree, so this rips it out end to end. Removed: - internal/spotlight package (Start/Stop/Sync/Status + tests) - taskyou_spotlight MCP tool (definition, handler, auto-approve entry) - TUI Spotlight/SpotlightSync keybindings, the 🔦 badge, help entries, and the toggle/sync commands (frees up f / F) - spotlight keybinding config fields + sample YAML - .spotlight-active gitignore rule and the SKILL.md doc entry Also pruned the now-stale multi-surface parity entries (desktop capabilities "Spotlight", parity-ignore "SpotlightSync") so the parity test stays green, and added a regression guard asserting taskyou_spotlight is no longer advertised in tools/list. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the spotlight feature entirely — Bruno never used it.
Spotlight let you sync a task worktree's git-tracked files back into the main repo (
start/stop/sync/status) so you could run the app against in-progress changes. It's been superseded by simply running the app from the worktree, so this rips it out across every surface: the Go package, the MCP tool, the TUI, config, docs, and the multi-surface parity manifests.Changes
internal/spotlight/— the whole package (Start/Stop/Sync/Status) and its tests.internal/mcp/server.go) — dropped thetaskyou_spotlighttool definition, its handler case, and the import; added a regression guard inserver_test.goasserting it's no longer advertised intools/list(and removed the ~530 lines of spotlight tests).taskyou_spotlightfrom the MCP auto-approve list and its tests.internal/ui/app.go,detail.go) — removed theSpotlight/SpotlightSynckeybindings, the 🔦 badge, help entries, thespotlightMsgtype, and thetoggleSpotlight/syncSpotlightcommands. This frees up thef/Fkeys.internal/config/keybindings.go) — removed thespotlight/spotlight_syncfields and sample YAML.desktop/capabilities.json"Spotlight",parity-ignore.json"SpotlightSync") sointernal/paritystays green..spotlight-active.gitignorerule and the SKILL.md doc entry.Net: +6 / −1829 lines.
Testing
go build ./...✅go test ./internal/{parity,mcp,config,executor,ui}/✅ all passgolangci-lint run(v2.8.0, matching CI) ✅ 0 issuesFollow-ups
None. Feature is fully removed;
f/Fare now available for reuse.🤖 Generated with Claude Code