Open
Conversation
Les tests passent et pycodestyle OK
Passe les tests et pycodestyle OK
bcalou
reviewed
Nov 17, 2023
Owner
bcalou
left a comment
bcalou
left a comment
There was a problem hiding this comment.
Très bien, beaucoup d'attention apportée à la clarté. Pas grand chose à dire !
__main__.py
Outdated
|
|
||
| def main() -> None: | ||
| print("Hello world") | ||
| date = input("Veuillez saisir une date au format YYYY-MM-DD: ") |
Owner
There was a problem hiding this comment.
Utiliser une boucle pour permettre à l'utilisateur de refaire une saisie en cas d'erreur
|
|
||
| def is_format_valid(date: str) -> bool: | ||
| """Verify if date follows the format YYYY-MM-DD""" | ||
| format_match = re.fullmatch(r"\d{4}[-]\d{1,2}[-]\d{1,2}", date) |
doomsday/does_date_exist.py
Outdated
| print("Veuillez saisir au date à partir de 1583-01-01") | ||
| return False | ||
|
|
||
| if not (0 < month < 13): |
Owner
There was a problem hiding this comment.
1 <= month <= 12
C'est du détail, mais humainement plus concret non?
Comment on lines
+4
to
+8
| # List of the offsets and exemples | ||
| # 2000 2 | ||
| # 1700/2100 0 | ||
| # 1800/2200 5 | ||
| # 1900/2300 3 |
Owner
|
Très bien structuré, facile à comprendre, bien formatté. C'est tout bon ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.