Skip to content

Get rid of get/set service inbuilts#33

Merged
forman merged 2 commits into
forman/v0.3.0from
forman/v0.3.0-service_wo_inbuilts
Jun 20, 2026
Merged

Get rid of get/set service inbuilts#33
forman merged 2 commits into
forman/v0.3.0from
forman/v0.3.0-service_wo_inbuilts

Conversation

@forman

@forman forman commented Jun 20, 2026

Copy link
Copy Markdown
Member

Summary

  • remove the built-in Service.get() query and Service.set() action
  • add dedicated store set / set_result protocol messages
  • make Python Service generic so service.store preserves Store[T]
  • keep store reads/writes on the Store API and service actions/queries for domain behavior
  • separate store broadcast suppression from service call context
  • fix tracked TS queries so update_task messages before query_result do not hang the promise

Details

  • StoreImpl.set() now sends SetMessage and waits for SetResultMessage
  • Python server dispatches SetMessage directly against the store
  • external Python-side store.set() broadcasts now use SetResultMessage(call_id="store_update")
  • user actions still batch multiple store.set() calls into one ActionResultMessage
  • get and set are no longer reserved service method names; notify remains reserved
  • local TS fallback no longer injects a hidden set action

Checklists

Python package

  • pixi run format
  • pixi run lint
  • pixi run mypy
  • pixi run tests
  • Updated remotestate-py/CHANGES.md

TypeScript library

  • npm run format
  • npm run checks
  • npm run tests
  • npm run build
  • Updated remotestate-ts/CHANGES.md

Demo app

  • npm run checks
  • npm run build
  • Updated remotestate-demo/CHANGES.md

@forman forman changed the title Forman/v0.3.0 service wo inbuilts Get rid of get/set service inbuilts Jun 20, 2026
@forman forman changed the base branch from main to forman/v0.3.0 June 20, 2026 10:09

@forman forman left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.

@forman forman marked this pull request as ready for review June 20, 2026 14:13
@forman forman merged commit 2a1f1af into forman/v0.3.0 Jun 20, 2026
6 checks passed
@forman forman deleted the forman/v0.3.0-service_wo_inbuilts branch June 20, 2026 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant