Skip to content

31296 - Update Correction Output Logic #4086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
meawong merged 2 commits into from
Feb 18, 2026
+10 −12
Merged

31296 - Update Correction Output Logic #4086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f98ecdf
31296 - Update correction output logic and tests
meawong Feb 17, 2026
f083545
31296 - lint fix
meawong Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions legal-api/src/legal_api/core/meta/filing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1009,11 +1009,14 @@ def alter_outputs_correction(filing, business, outputs):
"""Handle output file list modification for corrections."""
if filing.filing_type == "correction":
correction = filing.meta_data.get("correction", {})
if correction.get("commentOnly") and business.legal_type in Business.CORPS:
if not correction.get("correctionBenStatement"): # BEN correction statement require NOA
outputs.remove("noticeOfArticles")
else:
corrected_filing_type = filing.filing_json["filing"].get("correction", {}).get("correctedFilingType")
if (
correction.get("commentOnly") and
business.legal_type in Business.CORPS and
not correction.get("correctionBenStatement") # BEN correction statement require NOA
):
outputs.remove("noticeOfArticles")
if correction.get("toLegalName"):
corrected_filing_type = filing.meta_data.get("correction", {}).get("correctedFilingType")
if corrected_filing_type == "amalgamationApplication":
outputs.add("certificateOfAmalgamation")
elif corrected_filing_type == "continuationIn":
Expand All @@ -1023,9 +1026,9 @@ def alter_outputs_correction(filing, business, outputs):
business.legal_type != Business.LegalTypes.COOP.value
):
outputs.add("certificateOfIncorporation")
elif business.legal_type == Business.LegalTypes.COOP.value:
outputs.add("certificateOfNameCorrection")

if correction.get("toLegalName") and business.legal_type == Business.LegalTypes.COOP.value:
outputs.add("certificateOfNameCorrection")
if correction.get("uploadNewRules"):
outputs.add("certifiedRules")
if correction.get("uploadNewMemorandum"):
Expand Down
5 changes: 0 additions & 5 deletions legal-api/tests/unit/resources/v2/test_business_filings/test_filing_documents.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,6 @@ def test_unpaid_filing(session, client, jwt):
{'documents': {
'receipt': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/receipt',
'noticeOfArticles': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/noticeOfArticles',
'certificateOfIncorporation': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/certificateOfIncorporation',
'legalFilings': [
{'correction': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/correction'}
]
Expand All @@ -283,7 +282,6 @@ def test_unpaid_filing(session, client, jwt):
{'documents': {
'receipt': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/receipt',
'noticeOfArticles': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/noticeOfArticles',
'certificateOfIncorporation': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/certificateOfIncorporation',
'legalFilings': [
{'correction': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/correction'}
]
Expand All @@ -296,7 +294,6 @@ def test_unpaid_filing(session, client, jwt):
{'documents': {
'receipt': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/receipt',
'noticeOfArticles': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/noticeOfArticles',
'certificateOfIncorporation': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/certificateOfIncorporation',
'legalFilings': [
{'correction': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/correction'}
]
Expand All @@ -309,7 +306,6 @@ def test_unpaid_filing(session, client, jwt):
{'documents': {
'receipt': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/receipt',
'noticeOfArticles': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/noticeOfArticles',
'certificateOfIncorporation': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/certificateOfIncorporation',
'legalFilings': [
{'correction': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/correction'}
]
Expand All @@ -322,7 +318,6 @@ def test_unpaid_filing(session, client, jwt):
{'documents': {
'receipt': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/receipt',
'noticeOfArticles': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/noticeOfArticles',
'certificateOfIncorporation': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/certificateOfIncorporation',
'legalFilings': [
{'correction': f'{base_url}/api/v2/businesses/BC7654321/filings/1/documents/correction'}
]
Expand Down