Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5122 +/- ##
==========================================
+ Coverage 69.81% 69.82% +0.01%
==========================================
Files 410 410
Lines 17856 17863 +7
Branches 2000 2000
==========================================
+ Hits 12466 12473 +7
Misses 4765 4765
Partials 625 625 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
In |
backend/packages/wps-sfms/src/wps_sfms/interpolation/relative_humidity.py
Show resolved
Hide resolved
| 1. Interpolate dew point temperatures to a raster using IDW with elevation adjustment | ||
| (using the dew point lapse rate of 4.0°C/km, not the dry-bulb 6.5°C/km) |
There was a problem hiding this comment.
Where did the 4 degrees come from?
There was a problem hiding this comment.
It came from JE but I'm gonna run some further tests to see if the 2 degree standard will work.
There was a problem hiding this comment.
Back to 2 degrees now from: https://www.atmos.illinois.edu/~snodgrss/Airflow_over_mtn.html
There was a problem hiding this comment.
Could you please update the comment to reflect the 2*C and the source for that choice?
There was a problem hiding this comment.
Not directly related to this PR, but what are your guys thoughts on keeping everything related to "modern SFMS" (apart from db models/schemas) in the wps_sfms package? SFMS jobs included
@dgboss
There was a problem hiding this comment.
I think it's the ultimate goal, even the models/schema if unused by other packages should be separate and not in shared. I want to try to rework our devops pipeline before tackling this though.
There was a problem hiding this comment.
I agree with Conor, everything unique to a package should be contained within that package.
backend/packages/wps-sfms/src/wps_sfms/interpolation/relative_humidity.py
Show resolved
Hide resolved
backend/packages/wps-sfms/src/wps_sfms/interpolation/relative_humidity.py
Outdated
Show resolved
Hide resolved
backend/packages/wps-sfms/src/wps_sfms/interpolation/relative_humidity.py
Outdated
Show resolved
Hide resolved
backend/packages/wps-sfms/src/wps_sfms/interpolation/relative_humidity.py
Outdated
Show resolved
Hide resolved
backend/packages/wps-sfms/src/wps_sfms/interpolation/relative_humidity.py
Outdated
Show resolved
Hide resolved
…humidity.py Co-authored-by: dgboss <darren.boss@gov.bc.ca>
…humidity.py Co-authored-by: dgboss <darren.boss@gov.bc.ca>
|
| # This matches the CWFIS implementation | ||
| LAPSE_RATE = 0.0065 | ||
|
|
||
| # Dew point lapse rate: 2.0°C per 1000m: https://www.atmos.illinois.edu/~snodgrss/Airflow_over_mtn.html |
There was a problem hiding this comment.
This link doesn't work for me, might be temporary though
There was a problem hiding this comment.
I get
Service Unavailable
The server is temporarily unable to service your request due to maintenance downtime or capacity problems. Please try again later.
brettedw
left a comment
brettedw
left a comment
There was a problem hiding this comment.
Nice work, looks great!
3 participants
td_sea = td + elevation * 0.002td = td_sea - elevation * 0.002LapseRateAdjustedSourcebase class shared by temperature and dew point sourcesCloses #5103
Test Links:
Landing Page
MoreCast
Percentile Calculator
C-Haines
FireCalc
FireCalc bookmark
Auto Spatial Advisory (ASA)
HFI Calculator
SFMS Insights
Fire Watch