Open
Conversation
brettedw
commented
Feb 13, 2026
Comment on lines
-855
to
864
| select(FuelTypeRaster.id) | ||
| .where( | ||
| FuelTypeRaster.year | ||
| == select(func.max(FuelTypeRaster.year)).where( | ||
| FuelTypeRaster.id.in_( | ||
| select(AdvisoryZoneStatus.fuel_type_raster_id).where( | ||
| AdvisoryZoneStatus.run_parameters == run_parameter_id | ||
| ) | ||
| ) | ||
| ) | ||
| .join( | ||
| AdvisoryZoneStatus, | ||
| AdvisoryZoneStatus.fuel_type_raster_id == FuelTypeRaster.id, | ||
| ) | ||
| .where(AdvisoryZoneStatus.run_parameters == run_parameter_id) | ||
| .order_by(FuelTypeRaster.year.desc()) | ||
| .limit(1) | ||
| .scalar_subquery() | ||
| ) |
Collaborator
Author
There was a problem hiding this comment.
Subquery change was to avoid SA warning
SAWarning: implicitly coercing SELECT object to scalar subquery; please use the .scalar_subquery() method to produce a scalar subquery. FuelTypeRaster.year
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5128 +/- ##
=======================================
Coverage 69.81% 69.81%
=======================================
Files 410 410
Lines 17856 17856
Branches 2000 2000
=======================================
Hits 12466 12466
Misses 4765 4765
Partials 625 625 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AdvisoryZoneStatus.fuel_type_raster_id == most_recent_raster_subqueryhappening outside the left join was basically nullifying the left join and resulting in missing zones in the response. The result was any zone that had no advisory or warning pixels in it, would not show up in the tabs.Added test for this case
Test Links:
Landing Page
MoreCast
Percentile Calculator
C-Haines
FireCalc
FireCalc bookmark
Auto Spatial Advisory (ASA)
HFI Calculator
SFMS Insights
Fire Watch