add keywords for setting up dynesty and nautilus#389
Open
wangbingjie wants to merge 3 commits into
Open
Conversation
Owner
|
Hi @wangbingjie, thanks for this. My understanding from #348 was that the parameter inspection was supposed to automatically pass any sampling keywords that are present in run_params and known to the chosen sampling algorithm, is that wrong? That said, these would need to be added to the parser given by |
Contributor
Author
|
hum... I tried passing perhaps I did something dumb? |
Contributor
Owner
|
This looks like an issue with how the inspection is used to get sampler keywords. I think I can put a fix together that will be a bit more general. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, only
nliveandneffcould be passed to the samplers. This update provides a quick fix that allows most of the keywords accepted by dynesty and nautilus to be passed through to the corresponding samplers.