refactor: remove native_assets_cli dependency and add hooks package#84
Open
M3BIONIX wants to merge 1 commit intobdero:masterfrom
Open
refactor: remove native_assets_cli dependency and add hooks package#84M3BIONIX wants to merge 1 commit intobdero:masterfrom
M3BIONIX wants to merge 1 commit intobdero:masterfrom
Conversation
Author
|
@bdero Could you please review this ? |
jbbjarnason
reviewed
Oct 29, 2025
| flutter_scene_importer: | ||
| path: ./importer | ||
| hooks: ^0.20.4 | ||
| native_assets_cli: '>=0.13.0 <0.14.0' |
|
|
||
| import 'package:logging/logging.dart'; | ||
| import 'package:native_assets_cli/native_assets_cli.dart'; | ||
| import 'package:hooks/hooks.dart'; |
There was a problem hiding this comment.
similar change needed in flutter_app/hook/build.dart
Author
There was a problem hiding this comment.
Tried this, but as flutter_gpu_shaders still uses native assets inside the package, we get a type error for BuildInput and BuildOutput
Author
There was a problem hiding this comment.
Added a PR for the same bdero/flutter_gpu_shaders#11, once this gets merged will install the latest shaders and update it here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the package to use hooks as it was depricated to use hooks which replaced native-assets