Add hook for providing project id in the header of every request#29
Open
Add hook for providing project id in the header of every request#29
Conversation
The project id can now be added by initing the client module with an appropriate provider that fetches the current project id. For example, from the client state.
rgrinberg
force-pushed
the
interceptor-project-id
branch
from
67d6ecc to
ad6ad71
Compare
rgrinberg
force-pushed
the
interceptor-project-id
branch
from
a0139ce to
727e0b0
Compare
Collaborator
Author
|
OK I almost made this prototype work. I'm not really convinced this is the right idea though so I really would like to talk about this before proceeding further. The only thing that remains here is stripping off the project Id's before passing them to protege but all this really shows how fragile this entire approach is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project id can now be added by initing the client module with an appropriate
provider that fetches the current project id. For example, from the client state.