Open
Conversation
* properly convert server exceptions to 500's * include stack traces on uncaught exceptions. This should greatly ease debugging.
0a02ba2 to
447e665
Compare
Owner
|
Sending the 500 is ok, sending the stack trace might ease debugging but I'm -0 on that as it's the only use case I can see. We should be able to use the logs? |
Collaborator
Author
|
Yeah, but unfortunately looking up the logs in practice ends up being far less practical. There's either way too much logging when you run a test suite, or no useful logs at all until you remember to enable them. This PR is still useful enough for me to cherry pick on top of whatever i'm debugging however. So there's no hurry to merge it |
Owner
|
We can discuss next time we meet, in general I don't think this is a good idea when the only use is debugging. Locally this fine of course.
…Sent from my iPhone
On Aug 10, 2017, at 6:08 AM, Rudi Grinberg ***@***.***> wrote:
Yeah, but unfortunately looking up the logs in practice ends up being far less practical. There's either way too much logging when you run a test suite, or no useful logs at all until you remember to enable them. This PR is still useful enough for me to cherry pick on top of whatever i'm debugging however. So there's no hurry to merge it
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
debugging.
@AnthonyMl