Skip to content

Improve pellet exception handling#36

Open
rgrinberg wants to merge 1 commit intomasterfrom
pellet-exception-handling
Open

Improve pellet exception handling#36
rgrinberg wants to merge 1 commit intomasterfrom
pellet-exception-handling

Conversation

@rgrinberg
Copy link
Copy Markdown
Collaborator

  • properly convert server exceptions to 500's
  • include stack traces on uncaught exceptions. This should greatly ease
    debugging.

@AnthonyMl

* properly convert server exceptions to 500's
* include stack traces on uncaught exceptions. This should greatly ease
  debugging.
@rgrinberg rgrinberg force-pushed the pellet-exception-handling branch from 0a02ba2 to 447e665 Compare August 1, 2017 19:29
@bdionne
Copy link
Copy Markdown
Owner

bdionne commented Aug 3, 2017

Sending the 500 is ok, sending the stack trace might ease debugging but I'm -0 on that as it's the only use case I can see.

We should be able to use the logs?

@rgrinberg
Copy link
Copy Markdown
Collaborator Author

Yeah, but unfortunately looking up the logs in practice ends up being far less practical. There's either way too much logging when you run a test suite, or no useful logs at all until you remember to enable them. This PR is still useful enough for me to cherry pick on top of whatever i'm debugging however. So there's no hurry to merge it

@bdionne
Copy link
Copy Markdown
Owner

bdionne commented Aug 10, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants