Skip to content

Deduplicate direction selection code in Field.js. #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Pehat wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Deduplicate direction selection code in Field.js. #23

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3731de3
Deduplicate direction selection code in Field.js.
Pehat Apr 9, 2026
a933d4f
Deduplicate direction selection code in Field.js.
Pehat Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
84 changes: 31 additions & 53 deletions jsiso/tile/Field.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -929,61 +929,39 @@ function(EffectLoader, Emitter, utils) {
var particle, subPart;

distance = distance || tileHeight;
if (isometric) {
if (direction === "up") {
drawY += distance / 2 * curZoom;
drawX += distance * curZoom;
}
else if (direction === "down") {
drawY += distance / 2 * curZoom;
drawX -= distance * curZoom;
}
else if (direction === "left") {
drawY -= distance / 2 * curZoom;
drawX -= distance * curZoom;
}
else if (direction === "right") {
drawY -= distance / 2 * curZoom;
drawX += distance * curZoom;
}
}
else {
if (direction === "up") {
drawY += distance * curZoom;
// Offset moving for particle effect particles
for (particle in particleMapHolder) {
for (subPart in particleMapHolder[particle]) {
particleMapHolder[particle][subPart].ShiftBy(0, distance * curZoom);
}
}
}
else if (direction === "down") {
drawY -= distance * curZoom;
// Offset moving for particle effect particles
for (particle in particleMapHolder) {
for (subPart in particleMapHolder[particle]) {
particleMapHolder[particle][subPart].ShiftBy(0, -distance * curZoom);
}
}
}
else if (direction === "left") {
drawX += distance * curZoom;
// Offset moving for particle effect particles
for (particle in particleMapHolder) {
for (subPart in particleMapHolder[particle]) {
particleMapHolder[particle][subPart].ShiftBy(distance * curZoom, 0);
}
}
var scaled_step = distance * curZoom;

var _delta = {
false: {
"up": {"x": 0, "y": 1},
"down": {"x": 0, "y": -1},
"left": {"x": 1, "y": 0},
"right": {"x": -1, "y": 0}
},
true: {
"up": {"x": 1, "y": 0.5},
"down": {"x": -1, "y": 0.5},
"left": {"x": -1, "y": -0.5},
"right": {"x": 1, "y": -0.5}
}
else if (direction === "right") {
drawX -= distance * curZoom;
// Offset moving for particle effect particles
for (particle in particleMapHolder) {
for (subPart in particleMapHolder[particle]) {
particleMapHolder[particle][subPart].ShiftBy(-distance * curZoom, 0);
}
}[!!isometric][direction];

if !(_delta) return;

var _scaled_delta = {
"x": _delta.x * scaled_step,
"y": _delta.y * scaled_step
};
drawX += _scaled_delta.x;
drawY += _scaled_delta.y;

if (!isometric) {
// Offset moving for particle effect particles
for (particle in particleMapHolder) {
for (subPart in particleMapHolder[particle]) {
particleMapHolder[particle][subPart].ShiftBy(_scaled_delta.x, _scaled_delta.y);
}
}
}
}
}
};
Expand Down