✨ feat(secrets): improve secrets UX, icon lifecycle, and KV deprecation rollout#26
Merged
Conversation
Split forked config secret lists into collapsible Overrides and Inherited sections, with Overrides expanded by default and inherited rows visually de-emphasized. Add fork summary counts to config header and preserve query invalidation compatibility via a dedicated secrets view query key.
Use a Dialog-based drawer for the left navigation on all screens, controlled from TopBar. Persist open/closed state in localStorage and expose accessibility state via aria-expanded and aria-hidden.
Replace custom sidebar drawer wiring with shadcn SidebarProvider/Sidebar/SidebarInset/SidebarTrigger and add required registry primitives (sidebar, sheet, tooltip, separator, use-mobile). Update AGENTS guidance to enforce registry-first planning and KISS/DRY reuse order for future UI work.
Refactor TopBar to use native shadcn breadcrumb and responsive overflow actions on smaller viewports. Move theme toggle from topbar to sidebar footer, add breadcrumb primitive from shadcn registry, and capture the KISS/DRY responsive header pattern in frontend AGENTS guidance.
…ide recompute - Rewrite icon resolver to prioritize first-token matches before fallback tokens\n- Persist icon_source (auto/manual) and preserve manual overrides during recompute\n- Add POST /api/projects/<project>/secrets/icons/recompute endpoint\n- Add Project Settings button to trigger recompute and refresh queries\n- Extend backend tests for resolver/source/recompute behavior
 |
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Python |  |
Mar 4, 2026 11:11a.m. | Review ↗ |
| Docker | |
Mar 4, 2026 11:11a.m. | Review ↗ |
Extract internal-only services for key comparison and icon slug resolution while preserving public interfaces and response contracts. Add characterization tests for compare flags/malformed configs and icon default fallback when index is missing.
Apply staticmethod on helper/resource methods that do not use instance state and document local PYL-R0201 verification mapping in AGENTS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
autovsmanual) so manual icon choices remain stable while automatic icon updates can still be safely recomputed.POST /api/projects/<project_slug>/secrets/icons/recompute, plus a Config Settings UI action to refresh auto-assigned icons and report updated/skipped totals./api/secrets/kvsurfaces in layers (runtime warnings, OpenAPI deprecation flags, and deprecation response headers) while preserving endpoint availability for compatibility during the transition window.1.4.0to1.4.1and aligned related project/docs metadata to the new release.