Merged
Conversation
If the mime-type doesn't exist, the process should exit with 0.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the behavior change for the Wayland clipboard helper by ensuring that if the mime-type doesn't exist, the process exits with a success code.
- Modified the mime type determination logic in the Wayland clipboard code.
- Updated the error handling to return Ok() when the mime-type is not available.
| supported_types, | ||
| )?)?; | ||
| let mime_type = | ||
| if let Ok(type_str) = decide_mime_type(&state.config.expected_mime_type, supported_types) { |
There was a problem hiding this comment.
Consider adding a brief comment explaining that returning Ok() when the mime type is not found is intentional behavior as per the PR requirements.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the mime-type doesn't exist, the process should exit with 0.