doctor: ignore host .in_use heartbeat files in file audit#24
Merged
Conversation
Claude Code writes .in_use/<pid> heartbeat files into an installed
plugin cache root to mark the version as actively used so it is not
garbage-collected mid-session. The packed-install filesystem walk in
listFilesystemVisibleFiles swept them into the audited file set, so
`doctor` failed the fileAudit check ("File audit missing entries:
.in_use/<pid>") on every marketplace install with an active session.
Skip the .in_use directory in the walk (SKIP_FILESYSTEM_DIRS) and
treat .in_use/ paths as runtime files (isRuntimeFile), matching how
.superloopy runtime state is already handled.
Regression test: packed install seeded with .in_use/<pid> heartbeats
must pass doctor cleanly.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
superloopy doctorreportsok: falseon every Claude Code marketplace install that has (or had) an active session:Claude Code writes
.in_use/<pid>heartbeat files ({"pid":…,"procStart":…}) into the installed plugin cache root to mark that version as actively used so it is not garbage-collected mid-session. These are host runtime state, not shipped files.Root cause
The cache root has no
.git, solistGitVisibleFilesfalls back to the raw filesystem walk (listFilesystemVisibleFiles).SKIP_FILESYSTEM_DIRSdid not include.in_use, so the heartbeat files were swept into the audited file set; they are absent fromdocs/superloopy-file-audit.md, socheckFileAuditfails andrunDoctor's all-checks-must-pass aggregate flips the whole report took: false.This is the
.in_usesibling of the packed-install fileAudit false positive tracked in #14.Fix
.in_usetoSKIP_FILESYSTEM_DIRSso the walk never descends into it..in_use/paths as runtime files inisRuntimeFile, matching how.superloopy/runtime state is already handled.Testing
test/doctor-packed.test.js: an npm-packed install seeded with.in_use/<pid>heartbeat files must pass doctor cleanly. Verified red without the fix, green with it.doctor --rootagainst the real installed cache at~/.claude/plugins/cache/beefiker/superloopy/0.9.0(live heartbeat present) →ok: true.