ci: run the xbuild cross-compile on PR/main, and de-dup CI triggers#41
Merged
Conversation
The CGO binary's zig-cc cross-build for linux+windows amd64/arm64 lived only in release.yml (v* tags), so a cross-compile break — e.g. an engine change that only fails to build for Windows — first surfaced when tagging a release (v0.1.0 failed on the tile57 CLI's POSIX-only --tui). Add the same `make xbuild` as a job in ci.yml, floating the engine submodule to main like the other jobs, so it's caught before the tag. Build-health gate only; no artifact upload. Also scope `push` to main so a push to a branch with an open PR no longer fires both `push` and `pull_request` — otherwise every PR push would run the whole suite (now including the ~7-min xbuild) twice. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…fix) The xbuild CI job compiled the stale pinned engine (068474e3d), which predates the Windows cross-compile fix, so it hit the same `raw.lflag.ICANON` termios error on x86_64-windows-gnu. tile57 main (a2022b6, "Merge #1 fix/windows-cross-compile") has the fix; bump the committed submodule pin to it so the cross-build — and releases — build the fixed engine. Note: the "float tile57 to latest main" CI step actually reverts the submodule to the committed pin (a latent bug: the second `git submodule update --init --recursive tile57` run from the superproject resets tile57 back to the gitlink, undoing the preceding --remote float), so the pin is what CI really builds. Bumping the pin is what turns CI green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CGO binary's zig-cc cross-build for linux+windows amd64/arm64 lived only in release.yml (v* tags), so a cross-compile break — e.g. an engine change that only fails to build for Windows — first surfaced when tagging a release (v0.1.0 failed on the tile57 CLI's POSIX-only --tui). Add the same
make xbuildas a job in ci.yml, floating the engine submodule to main like the other jobs, so it's caught before the tag. Build-health gate only; no artifact upload.Also scope
pushto main so a push to a branch with an open PR no longer fires bothpushandpull_request— otherwise every PR push would run the whole suite (now including the ~7-min xbuild) twice.