fix(web): declutter text by S-52 importance, not anchor draw-order#9
Merged
Conversation
The general text fanned into nine per-anchor style layers (text-<halign>- <valign>) because text-anchor was historically not data-driven. MapLibre keeps one collision index but places symbols layer-by-layer, so a label's survival depended on WHICH anchor sublayer drew first (center-anchored always beat right-anchored) rather than on its importance. MapLibre 5.24 makes text-anchor and symbol-sort-key data-driven, so collapse the nine layers into one `text` layer: - text-anchor: data-driven match on the baked halign/valign (placement unchanged). - symbol-sort-key: ranked by S-52 §14.4 text group (tgrp) — important text (11) > names (21/26/29) > descriptive, minus font size for within-tier ties. Lower wins, so a dense approach thins to the navigationally important labels. - light-text keeps its own earlier always-wins layer, now with a size-based sort-key. Collapse the two live updaters (setScheme restyle, setMariner text-group filter) onto the single `text` id and drop the now-dead TEXT_VARIANTS/textAnchor. Pure client change, no re-bake. Verified on server-mode d5 Annapolis: same label budget but channel/feature names now survive collisions; text-group toggle and day/night restyle still work. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The general text fanned into nine per-anchor style layers (text-- ) because text-anchor was historically not data-driven. MapLibre keeps one collision index but places symbols layer-by-layer, so a label's survival depended on WHICH anchor sublayer drew first (center-anchored always beat right-anchored) rather than on its importance.
MapLibre 5.24 makes text-anchor and symbol-sort-key data-driven, so collapse the nine layers into one
textlayer:Collapse the two live updaters (setScheme restyle, setMariner text-group filter) onto the single
textid and drop the now-dead TEXT_VARIANTS/textAnchor.Pure client change, no re-bake. Verified on server-mode d5 Annapolis: same label budget but channel/feature names now survive collisions; text-group toggle and day/night restyle still work.