Conversation
Turned out to be required
This reverts commit 102420e. GitHub CI uses Visual Studio 2022
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
Thanks - this is obviously a little difficult to fully review without the corresponding Briefcase PR; but it looks to be broadly on the right track. A few comments inline.
| "pre_uninstall_script": "", | ||
| "python_version": "3.X.0", | ||
| "host_arch": "AMD64", | ||
| "configuration": "{{ 'ARM64' if cookiecutter.host_arch == 'ARM64' else 'x64' }}", |
There was a problem hiding this comment.
"configuration" is a little vague here - and internal to VSCode, I think "Configuration" is more about "Release" or "Debug"; maybe "vscode_platform"?
| <package id="pythonarm64" version="{{ cookiecutter.python_version|nuget_version }}" targetFramework="native" /> | ||
| {% else %} | ||
| <package id="python" version="{{ cookiecutter.python_version|nuget_version }}" targetFramework="native" /> | ||
| {% endif %} |
There was a problem hiding this comment.
If there no way for this to contain both, selected conditionally on which target is being used? Or, alternatively - produce two packages.config files selecting the right file as appropriate? It seems weird to have a VSCode file that works for both architectures, but a packages.config that only works for one.
There was a problem hiding this comment.
I couldn't find a way to do it dynamically. Looks like Visual Studio supports an alternative way of specifying packages in the project file (PackageReference) but the Platform property doesn't appear to be supported there.
freakboy3742
left a comment
freakboy3742
left a comment
There was a problem hiding this comment.
Thanks for those updates; this works great in conjunction with beeware/briefcase#2797 in my testing.
2 participants
This updates the template to work for ARM64:
I'll submit an accompanying PR for briefcase later.
Issue: beeware/briefcase#1887
PR Checklist: