Open
Conversation
Contributor
Author
|
The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
list_installed_system_images()utility method toAndroidSDKthat invokessdkmanager --list_installedand returns a set of installed system image package identifiers. Updatesverify_system_image()to use this method instead of only checking if the system image directory exists.Previously Briefcase verified a system image by checking if the expected directory existed. This check is not strong enough as the directory may exist wile the system image is incomplete or corrupted. This would cause a confusing error when either
avdmanageror the emulator would try to use an incomplete system image.Fixes #1895
PR Checklist: