Adopt os-log based logging.#2877
Merged
Merged
Conversation
This was referenced Jun 12, 2026
mhsmith
reviewed
Jun 13, 2026
| .specify/templates | ||
| .specify/extensions.yml | ||
| .specify/extensions | ||
| .specify/ |
Member
There was a problem hiding this comment.
Does this mean all the other .specify entries can be removed?
Member
Author
There was a problem hiding this comment.
Not sure what happened here - the entry should be ./specify/feature.json. I've pushed an update.
Member
Author
|
@mhsmith I'm going to merge this without a finalised review, because landing the iOS template means the current mainline Briefcase isn't able to view iOS logs, which is breaking Toga's CI (which will, in turn, cause problems with dependabot tomorrow). If you've got any deeper review comments, I'd still appreciate the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
macOS 26 changed the handling of default logging levels, so running a macOS app through Briefcase under macOS 26 results in the stdout content being displayed as
<private>.To work around this, we need to use an updated version of std-nslog which uses os_log rather than NSLog. However, this requires a binary module, which means the logger can't be loaded until app_packages has been added to the site path. This binary module requires a slightly different predicate pattern to extract log patterns.
However - as of Python 3.14, the functionality of std-nslog is baked into Python by default. As long as you're using 3.14.6+, you can get all of the functionality of std-nslog without importing the package. The predicate pattern here allows for native logging as well, and includes a cookiecutter extension to allow easy evaluation of whether the native shim can be used.
CI "Build app" tasks will fail on macOS until the templates are updated; the landing sequence will be to land the templates, then land this PR. See:
PR Checklist: