Skip to content

#38 Use SVG (Scalable Vector Graphics) for the splash screen instead …#43

Merged
sognefjellet merged 1 commit into
developfrom
bugfix/38-splash-screen-dpi
Jul 15, 2026
Merged

#38 Use SVG (Scalable Vector Graphics) for the splash screen instead …#43
sognefjellet merged 1 commit into
developfrom
bugfix/38-splash-screen-dpi

Conversation

@sognefjellet

@sognefjellet sognefjellet commented Jul 6, 2026

Copy link
Copy Markdown
Collaborator

…of a PNG (Portable Network Graphics) for DPI's > 100%.

@sognefjellet sognefjellet self-assigned this Jul 6, 2026
@github-actions

github-actions Bot commented Jul 6, 2026 •
edited
Loading

Copy link
Copy Markdown

Test Results

3 864 tests  ±0   3 864 ✅ ±0   9m 52s ⏱️ +23s
  158 suites ±0       0 💤 ±0 
  158 files   ±0       0 ❌ ±0 

Results for commit 27a8a0f. ± Comparison against base commit 4a85553.

This pull request removes 4 and adds 4 tests. Note that renamed tests count towards both. 
Tijd_Service.Serv_TestTijdsafhankelijkDoorgeeflu_0_Tests ‑ incomplete_prediction__ALEFS_1082__3__RestTest
Tijd_Service.Serv_TestTijdsafhankelijkDoorgeeflu_0_Tests ‑ incomplete_prediction__ALEFS_1082__3__SoapTest
Tijd_Service.Serv_TestTijdsafhankelijkDoorgeeflu_0_Tests ‑ invoer_geen_kenmerken__alefs_209__RestTest
Tijd_Service.Serv_TestTijdsafhankelijkDoorgeeflu_0_Tests ‑ invoer_geen_kenmerken__alefs_209__SoapTest

Tijd_Service.Serv_TestTijdsafhankelijkDoorgeeflu_1_Tests ‑ incomplete_prediction__ALEFS_1082__3__RestTest
Tijd_Service.Serv_TestTijdsafhankelijkDoorgeeflu_1_Tests ‑ incomplete_prediction__ALEFS_1082__3__SoapTest
Tijd_Service.Serv_TestTijdsafhankelijkDoorgeeflu_1_Tests ‑ invoer_geen_kenmerken__alefs_209__RestTest
Tijd_Service.Serv_TestTijdsafhankelijkDoorgeeflu_1_Tests ‑ invoer_geen_kenmerken__alefs_209__SoapTest

♻️ This comment has been updated with latest results.

@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

ALEF distributions (artifacts are deleted in 2 days):

@sognefjellet sognefjellet force-pushed the bugfix/38-splash-screen-dpi branch from 917434f to 57dcca8 Compare July 8, 2026 09:58
@sognefjellet sognefjellet force-pushed the bugfix/38-splash-screen-dpi branch from 57dcca8 to 37cdef5 Compare July 8, 2026 10:14
@sognefjellet sognefjellet marked this pull request as ready for review July 8, 2026 10:30
@sognefjellet sognefjellet requested a review from a team July 8, 2026 10:30
@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

ALEF distributions (artifacts are deleted in 2 days):

@github-actions

github-actions Bot commented Jul 8, 2026

Copy link
Copy Markdown

ALEF distributions (artifacts are deleted in 2 days):

brr-t
brr-t requested changes Jul 9, 2026
View reviewed changes

@brr-t brr-t left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Branch naam should be spelled as Branchnaam

  • Up to preference, but you might use Builddatum instead of Bouwdatum as build is a commonly used term in Dutch as well

  • Longer branchnames aren't truncacted anymore to fit within the white box

  • Fontsize in the upper box is inconsistent with the fontsize of the git hash

  • Fontsize is increased compared to the old splashscreen. I prefer the old (smaller) size

@BenDe23388

BenDe23388 commented Jul 9, 2026

Copy link
Copy Markdown
Collaborator
  • Branch naam should be spelled as Branchnaam
    A combination of Dutch and English might be best written with a hypen like: branch-naam.

@sognefjellet sognefjellet force-pushed the bugfix/38-splash-screen-dpi branch from 37cdef5 to 31c8bad Compare July 9, 2026 13:16
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

ALEF distributions (artifacts are deleted in 2 days):

um-ami
um-ami approved these changes Jul 11, 2026
View reviewed changes

@um-ami um-ami left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Windows with 3 different settings for dpi sclaing. All worked correctly both at atartup and from the Help menu.

Now I can reliably see which version of ALEF is active. When you switch to different versions as much as I do, this is no minor irriitation. So, thank you, for scratching this itch (almost rash)!

@BenDe23388 BenDe23388 linked an issue Jul 14, 2026 that may be closed by this pull request
Splash screen shows MPS 2025.1 on Windows with DPI > 100% #38
Closed
BenDe23388
BenDe23388 reviewed Jul 14, 2026
View reviewed changes

@BenDe23388 BenDe23388 left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created an internal build to verify that this builds here as well and for testers to try (and it looks like it works).

@BenDe23388 BenDe23388 requested a review from brr-t July 14, 2026 13:09
@brr-t

brr-t commented Jul 14, 2026

Copy link
Copy Markdown

Internal build is ok as well.

@sognefjellet
#38 Fix splash-screen for users that have a DPI > 100% by adding spla…
27a8a0f 
…sh@2x.png. To prevent multiple splash-screen files switched to the SVG (Scalable Vector Graphics) version of the splash-screen to generate the required splash.png and splash@2x.png from one source.
@sognefjellet sognefjellet force-pushed the bugfix/38-splash-screen-dpi branch from 31c8bad to 27a8a0f Compare July 14, 2026 16:17
@github-actions

github-actions Bot commented Jul 14, 2026

Copy link
Copy Markdown

ALEF distributions (artifacts are deleted in 2 days):

BenDe23388
BenDe23388 approved these changes Jul 15, 2026
View reviewed changes

@BenDe23388 BenDe23388 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works internally and on MacOS.

@sognefjellet sognefjellet merged commit 27a8a0f into develop Jul 15, 2026
3 checks passed
@sognefjellet sognefjellet deleted the bugfix/38-splash-screen-dpi branch July 15, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BenDe23388 BenDe23388 BenDe23388 approved these changes
@brr-t brr-t brr-t approved these changes
@um-ami um-ami um-ami approved these changes

Assignees

@sognefjellet sognefjellet

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Splash screen shows MPS 2025.1 on Windows with DPI > 100%

4 participants

@sognefjellet @BenDe23388 @brr-t @um-ami