docs: add publiccode.yml#46
Conversation
sognefjellet
left a comment
sognefjellet
left a comment
There was a problem hiding this comment.
Thank you for your contribution, this was on my To-do list 👍. I have a few suggestions (see comments).
|
|
||
| name: Agile Law Execution Factory (ALEF) | ||
| url: https://github.com/belastingdienst/ALEF.git | ||
| landingURL: https://wendbarewetsuitvoering.pleio.nl |
There was a problem hiding this comment.
I think you can better remove this line. The perforable lading page is the README.md
| name: Agile Law Execution Factory (ALEF) | ||
| url: https://github.com/belastingdienst/ALEF.git | ||
| landingURL: https://wendbarewetsuitvoering.pleio.nl | ||
| softwareType: standalone/desktop |
There was a problem hiding this comment.
I think the dependency MPS is needed:
dependsOn:
open:
- name: JetBrains MPS
optional: false| contacts: | ||
| - name: Bureau Open Source Software | ||
| email: bureauopensourcesoftware@belastingdienst.nl | ||
| affiliation: Belastingdienst |
There was a problem hiding this comment.
I think "Dutch Tax Administration (Belastingdienst)" is better her.
There was a problem hiding this comment.
@sognefjellet Sure! Do you have a contact emailaddress as well?
There was a problem hiding this comment.
bureauopensourcesoftware@belastingdienst.nl is ok for now. Bureau Open Source is the OSPO of the Dutch Tax Administration. I think that affiliation: Dutch Tax Administration (Belastingdienst) is better.
| developmentStatus: stable | ||
|
|
||
| description: | ||
| en: |
There was a problem hiding this comment.
Because RegelSpraak is in Dutch, is it smart to add here a Dutch description? Do you know if developer.overheid.nl shows in that case the Dutch text?
There was a problem hiding this comment.
Exactly as you state. If there is a Dutch description, we will show the Dutch version. Maybe you guys can add it lateron? I don't know the product too well myself.
There was a problem hiding this comment.
Nice, I will add this after your PR is merged. Can you squash your commits and (keep) this branch up-to date with develop so that you can merge it (rebase and merge)? For your PR this might feel a bit strange. We enforced an up-to-date branch and no merge commits to force a “fast-forward” merge because Git auto merging sometimes break the MPS XML files. So, merging should be done using MPS to prevent this. Consequences of this is that your branch needs to be up-to-date with develop to be able to merge it.
3 participants
I added a publiccode.yml for it to be seen on oss.developer.overheid.nl