Fix leak on allocation failure in ArrayBuffer#transfer#516
Closed
bptato wants to merge 1 commit into
Closed
Conversation
Move construction /before/ the buffer is detached, so that an allocation failure doesn't detach the backing buffer. This time I've left JS_NewArrayBuffer unchanged, and instead documented its existing ownership semantics. (I'm not sure if this is better, but at least there is no breaking change.)
Owner
|
Fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move construction /before/ the buffer is detached, so that an allocation failure doesn't detach the backing buffer. (My previous attempt just cleaned up the buffer in this case; this patch preserves it so it can still be used after catching the InternalError.)
This time I've left JS_NewArrayBuffer unchanged, and instead documented its existing ownership semantics. (I'm not sure if this is better, but at least there is no breaking change.)