Check return values of fallible functions#518
Merged
Conversation
Port of quickjs-ng/quickjs#1409 (bnoordhuis). I modified it to prevent an atom leak in js_parse_statement_or_decl, otherwise it's the same.
suchipi
added a commit
to suchipi/quickjs
that referenced
this pull request
Jun 14, 2026
…lard#518) Clean apply to src/quickjs/quickjs.c (byte-for-byte upstream's +8/-3). Three OOM-resilience checks: js_parse_for_in_of and js_parse_statement_or_decl now check dbuf_claim (return -1 / goto fail respectively), and JS_WriteObjectRec's JS_TAG_STRING_ROPE case captures and checks the recursive JS_WriteObjectRec return. Only fires on allocation failure; no behavior change in normal operation. test262 baselines unchanged. upstream: ccfe076
suchipi
added a commit
to suchipi/quickjs
that referenced
this pull request
Jun 14, 2026
…ellard#518) Ported in HEAD~1. Three OOM-resilience return-value checks in quickjs.c. No behavior change in normal operation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of quickjs-ng/quickjs#1409 (bnoordhuis).
I modified it to prevent an atom leak in js_parse_statement_or_decl, otherwise it's the same.