Skip to content
This repository was archived by the owner on Dec 23, 2022. It is now read-only.

Add some issues #1

Open
bellingard wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add some issues #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions backend/src/main/java/foo/Foo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,15 @@
*/
public class Foo {

public int i;
Copy link
Copy Markdown

@ghost ghost May 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Document this public field. rule
MAJOR Make i a static final constant or non-public and provide accessors if needed. rule


public static int div(int a, int b) {
if (b == 0) {
throw new UnsupportedOperationException("Can't divide by zero!");
}

System.out.println("foo");
Copy link
Copy Markdown

@ghost ghost May 10, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MAJOR Replace this usage of System.out or System.err by a logger. rule


return a / b;
}

Expand Down