Apply fusion optimization to input iterator#75
Merged
Conversation
bc3a294 to
97ff50b
Compare
97ff50b to
af0f7d0
Compare
af0f7d0 to
02d0090
Compare
foonathan
approved these changes
Jun 3, 2026
foonathan
left a comment
There was a problem hiding this comment.
I haven't looked into your implementation, but I can confirm that you are allowed to cache an input iterator: https://eel.is/c++draft/iterator.concept.readable#2
auto a = *it;
auto b = *it;
assert(a == b); // always true
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is made to expand the scope of a fused dispatch optimization based on the understanding that input iterators model the semantic requirement
*iis equality-preserving, which is to say that two evaluations of this expression with the same input must have equal outputs.This is why, for example,
std::ranges::istream_view<Val>cachesVal.