Skip to content

Enable beman-tidy (--require-all mode) into beman.indices_view#14

Open
neatudarius wants to merge 1 commit into
mainfrom
neatudarius-patch-1
Open

Enable beman-tidy (--require-all mode) into beman.indices_view#14
neatudarius wants to merge 1 commit into
mainfrom
neatudarius-patch-1

Conversation

@neatudarius

Copy link
Copy Markdown
Member

Issue: bemanproject/beman-tidy#256

Enable beman-tidy (--require-all mode) into beman.indices_view

Note: Badge check should be fixed before merge.

Issue: bemanproject/beman-tidy#256

Enable beman-tidy (--require-all mode) into beman.indices_view
@JeffGarland

Copy link
Copy Markdown
Member

@neatudarius I think this is ready? all the tidy checks are passing? @wermos any thoughts?

@JeffGarland JeffGarland self-requested a review May 15, 2026 00:23
@wermos

wermos commented May 16, 2026

Copy link
Copy Markdown
Collaborator

@wermos any thoughts?

The pre-commit check isn't passing yet:

Running check [Requirement][file.license_id] ... 
[error][file.license_id]: Missing SPDX-License-Identifier in .github/workflows/pre-commit-check.yml. Please add it at the first line. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#filelicense_id
[error][file.license_id]: Missing SPDX-License-Identifier in .markdownlint.yaml. Please add it at the first line. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#filelicense_id
[error][file.license_id]: Missing SPDX-License-Identifier in .pre-commit-config.yaml. Please add it at the first line. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#filelicense_id
[error][file.license_id]: Missing SPDX-License-Identifier in infra/.github/workflows/pre-commit.yml. Please add it at the first line. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#filelicense_id
[error][file.license_id]: Missing SPDX-License-Identifier in infra/.pre-commit-config.yaml. Please add it at the first line. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#filelicense_id
[error][file.license_id]: Missing SPDX-License-Identifier in infra/cmake/BuildTelemetry.cmake. Please add it at the first line. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#filelicense_id
[error][file.license_id]: Missing SPDX-License-Identifier in infra/cmake/BuildTelemetryConfig.cmake. Please add it at the first line. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#filelicense_id
[error][file.license_id]: Missing SPDX-License-Identifier in infra/cmake/telemetry.sh. Please add it at the first line. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#filelicense_id
[error][file.license_id]: Missing SPDX-License-Identifier in infra/cmake/use-fetch-content.cmake. Please add it at the first line. See https://github.com/bemanproject/beman/blob/main/docs/beman_standard.md#filelicense_id
	check [Requirement][file.license_id] ... failed

Some of these (.github/workflows/pre-commit-check.yml, .markdownlint.yaml, .pre-commit-config.yaml) can be fixed in the repo, but the other failures are from infra/, which means the license stuff needs to be added upstream and then we need to update our submodule.

I can handle the missing license IDs in the files in the repo, but I am not familiar with the process for updating the files in the infra/ directory.

@JeffGarland

Copy link
Copy Markdown
Member

I can handle the missing license IDs in the files in the repo, but I am not familiar with the process for updating the files in the infra/ directory.

@wermos I checked and they are fixed upstream in infra now -- so an update is probably in order. Can we fix the other ones and close this out?

@wermos

wermos commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator

Yep, the license issue is fixed.

The only failing check is this:

Running check [Requirement][release.godbolt_trunk_version] ... 
[error][release.godbolt_trunk_version]: The file 'README.md' does not contain a Compiler Explorer badge - trunk version assumed to be missing.
	check [Requirement][release.godbolt_trunk_version] ... failed

I don't think this library is available on Godbolt. What is the intended solution: add this on godbolt or make it so that the lint check doesn't ask for the godbolt badge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants