Skip to content

Fix smallest_size_t #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
20162026 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix smallest_size_t #130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions include/beman/inplace_vector/inplace_vector.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,10 @@ inline constexpr from_range_t from_range;
// Smallest unsigned integer that can represent values in [0, N].
template <size_t N>
using smallest_size_t
= std::conditional_t<(N < std::numeric_limits<uint8_t>::max()), uint8_t,
std::conditional_t<(N < std::numeric_limits<uint16_t>::max()), uint16_t,
std::conditional_t<(N < std::numeric_limits<uint32_t>::max()), uint32_t,
std::conditional_t<(N < std::numeric_limits<uint64_t>::max()), uint64_t,
= std::conditional_t<(N <= std::numeric_limits<uint8_t>::max()), uint8_t,
std::conditional_t<(N <= std::numeric_limits<uint16_t>::max()), uint16_t,
std::conditional_t<(N <= std::numeric_limits<uint32_t>::max()), uint32_t,
std::conditional_t<(N <= std::numeric_limits<uint64_t>::max()), uint64_t,
size_t>>>>;
// clang-format on

Expand Down
16 changes: 16 additions & 0 deletions tests/beman/inplace_vector/size_n_data.test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,25 @@
#include <gtest/gtest.h>
#include <numeric>

#include <cstdint>

#include "gtest_setup.hpp"

namespace {
// details::smallest_size_t — smallest unsigned integer holding values in [0, N]
using beman::inplace_vector::details::smallest_size_t;
static_assert(std::is_same_v<smallest_size_t<0>, uint8_t>);
static_assert(std::is_same_v<smallest_size_t<255>, uint8_t>);
static_assert(std::is_same_v<smallest_size_t<256>, uint16_t>);
static_assert(std::is_same_v<smallest_size_t<65535>, uint16_t>);
static_assert(std::is_same_v<smallest_size_t<65536>, uint32_t>);
static_assert(std::is_same_v<
smallest_size_t<std::numeric_limits<uint32_t>::max()>, uint32_t>);
static_assert(
std::is_same_v<
smallest_size_t<std::size_t{1} + std::numeric_limits<uint32_t>::max()>,
uint64_t>);

// 23.3.14.3 Size and capacity [inplace.vector.capacity]

template <typename Param> class SizeNCapacity : public IVBasicTest<Param> {};
Expand Down