Implement cross-capacity comparison#144
Open
ChronoInferna wants to merge 8 commits into
Open
Conversation
standardize test includes add license details
rename test move cross_capacity tests to compare.test.cpp
remove extra line
ChronoInferna
force-pushed
the
cross-capacity
branch
from
df0c1cc to
f4d06ff
Compare
Member
|
Thank you for updating the tests |
wusatosi
reviewed
May 26, 2026
Comment on lines
-401
to
-405
| constexpr friend bool operator==(const inplace_vector_base &x, | ||
| const inplace_vector_base &y) { | ||
| return x.size() == y.size() && std::ranges::equal(x, y); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
Can you add a macro to selectively enable P3698?
wusatosi
approved these changes
May 26, 2026
wusatosi
left a comment
wusatosi
left a comment
Member
There was a problem hiding this comment.
Thank you for your contribution
|
coverage: 98.649%. remained the same — ChronoInferna:cross-capacity into bemanproject:main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented cross-capacity comparison operators
operator==and<=>to resolve #95Also beautified the test files for consistency