Skip to content

Enable beman-tidy (--require-all mode)#29

Merged
JeffGarland merged 3 commits into
bemanproject:mainfrom
neatudarius:issue/261-require-all
May 15, 2026
Merged

Enable beman-tidy (--require-all mode)#29
JeffGarland merged 3 commits into
bemanproject:mainfrom
neatudarius:issue/261-require-all

Conversation

@neatudarius

@neatudarius neatudarius commented Apr 25, 2026

Copy link
Copy Markdown
Member

Issue: bemanproject/beman-tidy#261

Currently failing only release.godbolt_trunk_version with --require-all.

Summary:

Summary    Requirement:  21 checks passed, 1 checks failed, 3 checks skipped,  19 checks not implemented.
Summary Recommendation:  0 checks passed, 0 checks failed, 3 checks skipped,  0 checks not implemented.

NOTE: This PR will be merged after implementing release.godbolt_trunk_version. Details in bemanproject/beman-tidy#261 (comment).

@JeffGarland

Copy link
Copy Markdown
Member

I'm not sure I understand as this library isn't in godbolt at the moment, so how could it have a link? Should that just be a warning and not an error?

@neatudarius

Copy link
Copy Markdown
Member Author

I'm not sure I understand as this library isn't in godbolt at the moment, so how could it have a link? Should that just be a warning and not an error?

I'm not sure I understand as this library isn't in godbolt at the moment, so how could it have a link? Should that just be a warning and not an error?

@JeffGarland , I gave a detalied explanation here - bemanproject/beman-tidy#261 (comment).

Yes, this PR will be merged after having this library on godbolt.

@JeffGarland

Copy link
Copy Markdown
Member

See this PR which improves the examples and adds some godbolt links even though is just using the https header include #31

@neatudarius

Copy link
Copy Markdown
Member Author

See this PR which improves the examples and adds some godbolt links even though is just using the https header include #31

I think it's good enough!

@JeffGarland JeffGarland marked this pull request as ready for review May 15, 2026 00:18
@JeffGarland JeffGarland requested a review from nora77zz as a code owner May 15, 2026 00:18
@JeffGarland

Copy link
Copy Markdown
Member

@neatudarius I think this is all completed. Merging

@JeffGarland JeffGarland merged commit 07539ba into bemanproject:main May 15, 2026
80 of 81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants