Update README and add easy Heroku integration#13
Open
RF-Nelson wants to merge 14 commits intoben833:masterfrom
Open
Update README and add easy Heroku integration#13RF-Nelson wants to merge 14 commits intoben833:masterfrom
RF-Nelson wants to merge 14 commits intoben833:masterfrom
Conversation
RF-Nelson
changed the title
…s slack organization
Owner
|
I think this is good. It changes some URLs though, so I think I would have to test it out to make sure it still works. Also I saw that you forked this, is there any way we could keep development on this repo? |
`git push heroku master` fails for a non-semvar version string.
Make package.json version valid
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I expect many potential users will be looking to use Heroku to host slack-vote because it's free and easy to setup for something like this.
I added some commented-out code in persist.js that will need to be activated if a user wants to use Heroku Redis.
I also fleshed out the README to include explicit instructions for setting up the outgoing webhook configurations as well as the Heroku setup.