fix(nats): apply TLS replica options#1362
Open
corylanou wants to merge 2 commits into
Open
Conversation
PR Build Metrics✅ All clear — no issues detected
Binary Size
Dependency ChangesNo dependency changes. govulncheck OutputBuild Info
History (1 previous)
🤖 Updated on each push. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply every NATS replica TLS setting when constructing the NATS client options.
Problem
The
tls:YAML setting parsed successfully but was dropped bynewNATSReplicaClientFromConfig(). The NATS client also no longer addednats.Secure()for explicit TLS after PR #720 replaced the original TLS branch with certificate helpers.Before the fix, the regression test failed with:
Root CA and client certificate settings still auto-enabled TLS, which masked the missing explicit TLS path.
Solution
nats.Secure()when explicit TLS is enabled.Scope
In scope:
Not in scope:
Test Plan
Related
Fixes #1352