Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #62 +/- ##
==========================================
- Coverage 74.40% 74.26% -0.15%
==========================================
Files 25 26 +1
Lines 801 847 +46
==========================================
+ Hits 596 629 +33
- Misses 181 191 +10
- Partials 24 27 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
This was referenced Nov 6, 2022
ced71cd to
3492ed9
Compare
- implement AssertEqualRunners, EqualRunners, DiffRunner - Unit test exposed functions
83a2213 to
243547c
Compare
moreirathomas
approved these changes
Mar 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Package
benchttptestprovides utilities for benchttp testing.It exposes comparison utilities to be used by benchttp consumers in their tests:
configparse/configio,benchttp/cli.configflag, and any source that needs to ensure it creates or retrieves an expectedbenchttp.Runner.Currently exposed functions:
It uses
go-cmpinternally, which allows to fine-tune equality checks contrary toreflect.DeepEqual.However it has some severe rules regarding immutability and I haven't managed to tweak it around
Request.Body, as it cannot be read without mutation. As a work-around we simply compare the body separately (and restore it afterwards).Changes
No changes to the existing in this PR. However it makes tests much simpler in the following PRs:
Notes