Skip to content

fix(tailscale-exit-nodes): lock AWS firewall after instance is running #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bendwyer merged 1 commit into from
Jun 29, 2026
Merged

fix(tailscale-exit-nodes): lock AWS firewall after instance is running #80

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions images/tailscale-exit-nodes/src/saga.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ const defaultSleep = (ms: number): Promise<void> =>

/**
* Run the full provisioning saga: mint a key, create the instance, record its
* handles, lock the firewall (AWS), poll for readiness, then mark active. Any
* handles, poll for readiness, lock the firewall (AWS), then mark active. Any
* failure is recorded on the row as `failed` (the reaper reconciles it) and
* swallowed — the saga runs detached, so there is no caller to throw to.
*/
Expand All @@ -163,10 +163,6 @@ export async function provisionSaga(
// it even if a later step fails.
await db.updateInstanceRefs(params.deploymentId, refs.instanceRef, refs.firewallRef);

if (params.provider === 'aws') {
await lockLightsailFirewall(creds, refs.instanceRef, params.providerRegion);
}

let publicIp: string | null = null;
for (let attempt = 1; attempt <= pollAttempts; attempt++) {
publicIp = await checkInstanceReady(creds, params, refs.instanceRef);
Expand All @@ -177,6 +173,13 @@ export async function provisionSaga(
throw new Error(`instance ${refs.instanceRef} did not become ready in time`);
}

// AWS only: lock the public firewall to UDP 41641. This MUST run after the
// instance is `running` — Lightsail rejects PutInstancePublicPorts while the
// instance is still in transition (pending). Vultr locks down at create time.
if (params.provider === 'aws') {
await lockLightsailFirewall(creds, refs.instanceRef, params.providerRegion);
}

await db.markActive(params.deploymentId, publicIp);
console.log(
`provision ${params.deploymentId} active provider=${params.provider} ip=${publicIp}`,
Expand Down