Fix AccountBuilder naming: enforce explicit name and duplicate name check#628
Open
Devadakene wants to merge 1 commit into
Open
Fix AccountBuilder naming: enforce explicit name and duplicate name check#628Devadakene wants to merge 1 commit into
Devadakene wants to merge 1 commit into
Conversation
|
@Devadakene Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #541
Summary
AccountBuilder::newnow initializes with an empty name.AccountBuilder::buildvalidates that a name is set; otherwise, it panics with a helpful message.MockEnv::register_accountnow checks for duplicate names and panics if the name already exists.Impact
Prevents silent overwriting of accounts in
MockEnvand forces explicit, unique naming for accounts. Existing code that relied on the implicit “unnamed” default must be updated to set a name via.name("…")before calling.build().